feat: add features for other tls types#465
Closed
ctrlaltf24 wants to merge 4 commits into1c3t3a:mainfrom
Closed
Conversation
Turned out to be rather easy due to all tls being handled by our dependencies. Don't love the _fallback-tls feature, however with it we can use cargo-all-features, which helps reduce feature related bugs. Downside of cargo-all-features is it takes a long time to execute. Fixes: 1c3t3a#407, 1c3t3a#366
There's still an error with ci. engineio/src/lib.rs/test/tls_connector doesn't function the same as native-tls one (as it properly validates hostnames) Needs further investigation as to why the hostname shows as invalid in ci. If we no longer need that, then this PR can be merged.
ctrlaltf24
force-pushed
the
feat-add-features-for-other-tls-types
branch
from
2328485 to
4ea65ec
Compare
Collaborator
Author
|
Ran out of time. Need to still resolve the CI issue where for some reason the certificates are showing up as invalid hostnames. If someone could fix that bug, this would be ready to go. |
1c3t3a
reviewed
Nov 24, 2024
Owner
1c3t3a
left a comment
1c3t3a
left a comment
There was a problem hiding this comment.
Quick drive-by comments. As always: Nice work!
Comment on lines
+33
to
+36
| # rustls-pemfile is only needed for unit tests | ||
| rustls-pemfile = { version = "2", optional = true } | ||
| # webpki is only needed for unit tests | ||
| webpki = { version = "0.21", optional = true } |
Owner
There was a problem hiding this comment.
nit: Maybe make it a dev-dependency then?
Comment on lines
+51
to
+55
| #[cfg(feature = "async-callbacks")] on_close: OptionalCallback<()>, | ||
| #[cfg(feature = "async-callbacks")] on_data: OptionalCallback<Bytes>, | ||
| #[cfg(feature = "async-callbacks")] on_error: OptionalCallback<String>, | ||
| #[cfg(feature = "async-callbacks")] on_open: OptionalCallback<()>, | ||
| #[cfg(feature = "async-callbacks")] on_packet: OptionalCallback<Packet>, |
Owner
There was a problem hiding this comment.
Nice to see that feature properly implemented!
Contributor
|
any update for this PR? |
|
why was this PR closed? |
Contributor
Because it got superseeded by #497 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turned out to be rather easy due to all tls being handled by our dependencies.
Don't love the _fallback-tls feature, however with it we can use cargo-all-features, which helps reduce feature related bugs.
Downside of cargo-all-features is it takes a long time to execute.
Fixes: #407, #366
cc: @GaryCraft @tyilo @rageshkrishna